Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updates to opensource and definitions #1519

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: updates to opensource and definitions #1519

wants to merge 6 commits into from
+156 −151

Conversation

nathanbogale
Copy link
Contributor

@nathanbogale nathanbogale commented Jan 14, 2025 •
edited
Loading

Description

  • Modified the opensource section to meet with the requirement from ops team
  • added meta information to the proposal, that can be updated and give some guidance
  • modified patterns of some definitions

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 386/386}$ | ${\color{red}Fail: 0/386}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

@nathanbogale nathanbogale requested a review from stevenj January 15, 2025 17:50
nathanbogale and others added 2 commits January 16, 2025 20:30
@nathanbogale @stevenj
Update docs/src/architecture/08_concepts/document_templates/proposal/…
c7ba331 
…F14-Generic/0ce8ab38-9258-4fbc-a62e-7faa6e58318f.schema.json

Co-authored-by: Steven Johnson <[email protected]>
@nathanbogale
fix: enforced https
b401a2a
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

stevenj
stevenj approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj enabled auto-merge (squash) January 17, 2025 07:09
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 390/390}$ | ${\color{red}Fail: 0/390}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj stevenj approved these changes

@neil-iohk neil-iohk Awaiting requested review from neil-iohk neil-iohk is a code owner

@minikin minikin Awaiting requested review from minikin minikin is a code owner

Assignees

@nathanbogale nathanbogale

Labels
None yet
Projects
Catalyst
Status: 🔖 Ready
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanbogale @stevenj